Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowing ability to create a collection #2

Merged
merged 24 commits into from
Aug 28, 2024
Merged

Allowing ability to create a collection #2

merged 24 commits into from
Aug 28, 2024

Conversation

JackLewis-digirati
Copy link
Collaborator

@JackLewis-digirati JackLewis-digirati commented Aug 21, 2024 •
edited
Loading

This PR adds the ability to create a collection, as well as implementing an initial attempt at creating a build

Base automatically changed from feature/storageRootApi to main August 21, 2024 13:26
donaldgray
donaldgray approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@donaldgray donaldgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think there are more up to date versions of some actions used - can fixup now or dependabot will later (behaviour won't have changed)

.github/actions/docker-build-and-push/action.yml Outdated Show resolved Hide resolved
.github/workflows/run_build.yml Show resolved Hide resolved
.github/workflows/run_build.yml Show resolved Hide resolved
.github/workflows/run_build.yml Outdated Show resolved Hide resolved
Dockerfile.API Outdated Show resolved Hide resolved
src/IIIFPresentation/AWS/AWS.csproj Outdated Show resolved Hide resolved
src/IIIFPresentation/Migrator/Dockerfile Outdated Show resolved Hide resolved
src/IIIFPresentation/Models/API/Collection/HierarchicalCollection.cs Outdated Show resolved Hide resolved
src/IIIFPresentation/Models/API/Collection/FlatCollection.cs Show resolved Hide resolved
src/IIIFPresentation/Repository/Repository.csproj Show resolved Hide resolved
@JackLewis-digirati JackLewis-digirati merged commit 5d00048 into main Aug 28, 2024
3 checks passed
@JackLewis-digirati JackLewis-digirati deleted the feature/createCollection branch August 28, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@griffri griffri griffri left review comments

@donaldgray donaldgray donaldgray approved these changes

@tomcrane tomcrane Awaiting requested review from tomcrane

@p-kaczynski p-kaczynski Awaiting requested review from p-kaczynski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackLewis-digirati @donaldgray @griffri